Minor code style fixes
authorAlexander Ebert <ebert@woltlab.com>
Thu, 13 Jul 2017 12:21:04 +0000 (14:21 +0200)
committerAlexander Ebert <ebert@woltlab.com>
Thu, 13 Jul 2017 12:21:04 +0000 (14:21 +0200)
wcfsetup/install/files/lib/data/devtools/project/DevtoolsProject.class.php
wcfsetup/install/files/lib/data/package/installation/plugin/PackageInstallationPluginAction.class.php
wcfsetup/install/files/lib/system/devtools/package/DevtoolsInstaller.class.php
wcfsetup/install/files/lib/system/devtools/pip/DevtoolsPackageInstallationQueue.class.php
wcfsetup/install/files/lib/system/devtools/pip/DevtoolsPip.class.php

index c8f716e91c1f9f22cfd7121a7130980c5de57050..6d036c39babb05bf2d700e81bfb0203f64365be4 100644 (file)
@@ -1,9 +1,9 @@
 <?php
 namespace wcf\data\devtools\project;
-use wcf\data\DatabaseObject;
 use wcf\data\package\installation\plugin\PackageInstallationPluginList;
 use wcf\data\package\Package;
 use wcf\data\package\PackageCache;
+use wcf\data\DatabaseObject;
 use wcf\system\devtools\package\DevtoolsPackageArchive;
 use wcf\system\devtools\pip\DevtoolsPip;
 use wcf\system\package\validation\PackageValidationException;
index de704dcb5d4d97fb8bbc36f98bc41f24fc0f3c4b..7da39513a35d59d1c79c0b8656a84e8191661747 100644 (file)
@@ -1,7 +1,7 @@
 <?php
 namespace wcf\data\package\installation\plugin;
-use wcf\data\AbstractDatabaseObjectAction;
 use wcf\data\devtools\project\DevtoolsProject;
+use wcf\data\AbstractDatabaseObjectAction;
 use wcf\system\cache\CacheHandler;
 use wcf\system\devtools\pip\DevtoolsPackageInstallationDispatcher;
 use wcf\system\devtools\pip\DevtoolsPip;
@@ -51,6 +51,12 @@ class PackageInstallationPluginAction extends AbstractDatabaseObjectAction {
         */
        public $project;
        
+       /**
+        * Validates parameters to invoke a single PIP.
+        * 
+        * @throws      PermissionDeniedException
+        * @throws      UserInputException
+        */
        public function validateInvoke() {
                if (!ENABLE_DEVELOPER_TOOLS || !WCF::getSession()->getPermission('admin.configuration.package.canInstallPackage')) {
                        throw new PermissionDeniedException();
@@ -77,6 +83,11 @@ class PackageInstallationPluginAction extends AbstractDatabaseObjectAction {
                }
        }
        
+       /**
+        * Invokes a single PIP and returns the time needed to process it.
+        * 
+        * @return      string[]
+        */
        public function invoke() {
                $dispatcher = new DevtoolsPackageInstallationDispatcher($this->project);
                /** @var IIdempotentPackageInstallationPlugin $pip */
@@ -104,7 +115,6 @@ class PackageInstallationPluginAction extends AbstractDatabaseObjectAction {
                
                CacheHandler::getInstance()->flushAll();
                
-               
                return [
                        'pluginName' => $this->packageInstallationPlugin->pluginName,
                        'target' => $this->parameters['target'],
index f1a13899d5fee2270a9cd340b1ef8b9c1df708e4..f034dee16519b40c3eb5b906e7fbb8c1dbb5488c 100644 (file)
@@ -33,4 +33,4 @@ class DevtoolsInstaller extends Installer {
        public function getTar($source) {
                return $this->project->getPackageArchive()->getTar();
        }
-}
\ No newline at end of file
+}
index 31ff90d0b5f74a9acde114d501ae28829d664101..049678df340396064efd3aa015f46283e550cb77 100644 (file)
@@ -31,4 +31,4 @@ class DevtoolsPackageInstallationQueue extends PackageInstallationQueue {
                        'isApplication' => $project->getPackage()->isApplication
                ]);
        }
-}
\ No newline at end of file
+}
index 9d778ab80ca9c0a9ce854b065ae71476abb99c92..c9ca99319fad2797843a3062581bf797429244e6 100644 (file)
@@ -297,8 +297,6 @@ class DevtoolsPip extends DatabaseObjectDecorator {
                                        
                                        return $filename;
                        }
-                       
-                       
                }
        }
-}
\ No newline at end of file
+}