mfd: ab8500-gpadc: Pass the IRQF_ONESHOT flag
authorFabio Estevam <fabio.estevam@freescale.com>
Sat, 16 May 2015 18:42:16 +0000 (15:42 -0300)
committerLee Jones <lee.jones@linaro.org>
Mon, 22 Jun 2015 11:25:28 +0000 (12:25 +0100)
Since commit 1c6c69525b40eb76de8adf039409722015927dc3 ("genirq: Reject
bogus threaded irq requests") threaded IRQs without a primary handler
need to be requested with IRQF_ONESHOT, otherwise the request will fail.

So pass the IRQF_ONESHOT flag in this case.

The semantic patch that makes this change is available
in scripts/coccinelle/misc/irqf_oneshot.cocci.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
drivers/mfd/ab8500-gpadc.c

index dabbc93abdd717e5c40632b2d6b49209fb7149eb..c51c1b188d6401cb36fe77e5d05c0d55a95fa579 100644 (file)
@@ -948,7 +948,8 @@ static int ab8500_gpadc_probe(struct platform_device *pdev)
        if (gpadc->irq_sw >= 0) {
                ret = request_threaded_irq(gpadc->irq_sw, NULL,
                        ab8500_bm_gpadcconvend_handler,
-                       IRQF_NO_SUSPEND | IRQF_SHARED, "ab8500-gpadc-sw",
+                       IRQF_NO_SUSPEND | IRQF_SHARED | IRQF_ONESHOT,
+                       "ab8500-gpadc-sw",
                        gpadc);
                if (ret < 0) {
                        dev_err(gpadc->dev,
@@ -961,7 +962,8 @@ static int ab8500_gpadc_probe(struct platform_device *pdev)
        if (gpadc->irq_hw >= 0) {
                ret = request_threaded_irq(gpadc->irq_hw, NULL,
                        ab8500_bm_gpadcconvend_handler,
-                       IRQF_NO_SUSPEND | IRQF_SHARED, "ab8500-gpadc-hw",
+                       IRQF_NO_SUSPEND | IRQF_SHARED | IRQF_ONESHOT,
+                       "ab8500-gpadc-hw",
                        gpadc);
                if (ret < 0) {
                        dev_err(gpadc->dev,