nubus: Kill nubus_proc_detach_device()
authorGeert Uytterhoeven <geert@linux-m68k.org>
Fri, 3 May 2013 20:20:38 +0000 (22:20 +0200)
committerAl Viro <viro@zeniv.linux.org.uk>
Sat, 4 May 2013 18:47:26 +0000 (14:47 -0400)
Commit 59d8053f1e16904d54ed7469d4b36801ea6b8f2c ("proc: Move non-public
stuff from linux/proc_fs.h to fs/proc/internal.h") broke Apple NuBus
support:

drivers/nubus/proc.c: In function ‘nubus_proc_detach_device’:
drivers/nubus/proc.c:156: error: dereferencing pointer to incomplete type
drivers/nubus/proc.c:158: error: dereferencing pointer to incomplete type

Fortunately nubus_proc_detach_device() is unused, and appears to have never
been used, so just remove it.

Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
drivers/nubus/proc.c
include/linux/nubus.h

index b8286ed65919304c8960488c2c0c3a457bbfcf40..5371b374f1fe1a870c561b8392d55f4e4bafb941 100644 (file)
@@ -147,21 +147,6 @@ int nubus_proc_attach_device(struct nubus_dev *dev)
 }
 EXPORT_SYMBOL(nubus_proc_attach_device);
 
-/* FIXME: this is certainly broken! */
-int nubus_proc_detach_device(struct nubus_dev *dev)
-{
-       struct proc_dir_entry *e;
-
-       if ((e = dev->procdir)) {
-               if (atomic_read(&e->count))
-                       return -EBUSY;
-               remove_proc_entry(e->name, proc_bus_nubus_dir);
-               dev->procdir = NULL;
-       }
-       return 0;
-}
-EXPORT_SYMBOL(nubus_proc_detach_device);
-
 /*
  * /proc/nubus stuff
  */
index b3740527571aa9fc6ef6449e589d1edbe17aeb3e..6165b2c620408a7ee5d956d703f714275740e255 100644 (file)
@@ -87,7 +87,6 @@ static inline void nubus_proc_init(void) {}
 #endif
 int get_nubus_list(char *buf);
 int nubus_proc_attach_device(struct nubus_dev *dev);
-int nubus_proc_detach_device(struct nubus_dev *dev);
 /* If we need more precision we can add some more of these */
 struct nubus_dev* nubus_find_device(unsigned short category,
                                    unsigned short type,