net: ll_temac: Use of_property_read_u32 instead of open-coding it
authorTobias Klauser <tklauser@distanz.ch>
Wed, 23 Sep 2015 07:20:02 +0000 (09:20 +0200)
committerDavid S. Miller <davem@davemloft.net>
Thu, 24 Sep 2015 21:30:00 +0000 (14:30 -0700)
Use of_property_read_u32 to read the "clock-frequency" property instead
of using of_get_property with return value checks.

Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
Reviewed-by: Sören Brinkmann <soren.brinkmann@xilinx.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/xilinx/ll_temac_mdio.c

index 8cf9d4f56bb2223893dd912e1d475a48fc30f683..415de1eaf6412665fbaba35b7e67742819ebacd5 100644 (file)
@@ -59,16 +59,15 @@ static int temac_mdio_write(struct mii_bus *bus, int phy_id, int reg, u16 val)
 int temac_mdio_setup(struct temac_local *lp, struct device_node *np)
 {
        struct mii_bus *bus;
-       const u32 *bus_hz;
+       u32 bus_hz;
        int clk_div;
-       int rc, size;
+       int rc;
        struct resource res;
 
        /* Calculate a reasonable divisor for the clock rate */
        clk_div = 0x3f; /* worst-case default setting */
-       bus_hz = of_get_property(np, "clock-frequency", &size);
-       if (bus_hz && size >= sizeof(*bus_hz)) {
-               clk_div = (*bus_hz) / (2500 * 1000 * 2) - 1;
+       if (of_property_read_u32(np, "clock-frequency", &bus_hz) == 0) {
+               clk_div = bus_hz / (2500 * 1000 * 2) - 1;
                if (clk_div < 1)
                        clk_div = 1;
                if (clk_div > 0x3f)