bonding: remove no longer relevant vlan warnings
authorJiri Pirko <jiri@resnulli.us>
Wed, 2 Jul 2014 09:55:38 +0000 (11:55 +0200)
committerDavid S. Miller <davem@davemloft.net>
Tue, 8 Jul 2014 04:31:54 +0000 (21:31 -0700)
These warnings are no longer relevant. Even when last slave is
removed, there is a valid address assigned to bond (random).
The correct functionality of vlans is ensured by maintaining unicast
list in vlan_sync_address().

Suggested-by: Jay Vosburgh <jay.vosburgh@canonical.com>
Signed-off-by: Jiri Pirko <jiri@resnulli.us>
Acked-by: Veaceslav Falico <vfalico@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/bonding/bond_main.c

index ffefb704b529e47c67adc349e3524929b8506b23..09dc3ef771a7d5ba85c0f075d873fbea7be4752f 100644 (file)
@@ -1754,13 +1754,6 @@ static int __bond_release_one(struct net_device *bond_dev,
        if (!bond_has_slaves(bond)) {
                bond_set_carrier(bond);
                eth_hw_addr_random(bond_dev);
-
-               if (vlan_uses_dev(bond_dev)) {
-                       pr_warn("%s: Warning: clearing HW address of %s while it still has VLANs\n",
-                               bond_dev->name, bond_dev->name);
-                       pr_warn("%s: When re-adding slaves, make sure the bond's HW address matches its VLANs\n",
-                               bond_dev->name);
-               }
        }
 
        unblock_netpoll_tx();