serial: 8250_uniphier: call clk_disable_unprepare() on failure path
authorMasahiro Yamada <yamada.masahiro@socionext.com>
Fri, 24 Jul 2015 06:58:28 +0000 (15:58 +0900)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 3 Aug 2015 22:51:19 +0000 (15:51 -0700)
If serial8250_register_8250_port() fails, disable and unprepare the
clock before exiting.

Fixes: 1a8d2903cb6a ("serial: 8250_uniphier: add UniPhier serial driver")
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/8250/8250_uniphier.c

index 7d79425c2b09377f76282b917c5560511c27940f..d11621e2cf1df083ca4c58309ef610df6c9c70fa 100644 (file)
@@ -218,6 +218,7 @@ static int uniphier_uart_probe(struct platform_device *pdev)
        ret = serial8250_register_8250_port(&up);
        if (ret < 0) {
                dev_err(dev, "failed to register 8250 port\n");
+               clk_disable_unprepare(priv->clk);
                return ret;
        }