Revert "l2tp: constify inet6_protocol structures"
authorJulia Lawall <julia.lawall@lip6.fr>
Tue, 1 Aug 2017 16:27:29 +0000 (18:27 +0200)
committerDavid S. Miller <davem@davemloft.net>
Tue, 1 Aug 2017 17:03:17 +0000 (10:03 -0700)
This reverts commit d04916a48ad4a3db892b664fa9c3a2a693c378ad.

inet6_add_protocol and inet6_del_protocol include casts that remove the
effect of the const annotation on their parameter, leading to possible
runtime crashes.

Reported-by: Eric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/l2tp/l2tp_ip6.c

index d2efcd93e1e2d5489e3cf0aa068f0943761320f2..88b397c30d86af8d6a22daeb466cedac36aac57e 100644 (file)
@@ -788,7 +788,7 @@ static struct inet_protosw l2tp_ip6_protosw = {
        .ops            = &l2tp_ip6_ops,
 };
 
-static const struct inet6_protocol l2tp_ip6_protocol = {
+static struct inet6_protocol l2tp_ip6_protocol __read_mostly = {
        .handler        = l2tp_ip6_recv,
 };