perf probe: Fix to get ummapped symbol address on kernel
authorMasami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Sun, 22 Mar 2015 11:40:22 +0000 (20:40 +0900)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Tue, 24 Mar 2015 15:07:04 +0000 (12:07 -0300)
Fix to get correctly unmapped symbol address on kernel.  This allows us
to probe on syscall symbols which are aliases of SyS_ functions with
using debuginfo.

Without this fix:
  ----
  # ./perf probe -a sys_write
  Failed to find debug information for address 3b0100
  Probe point 'sys_write' not found.
    Error: Failed to add events.
  ----
The address 0x3b0100 is a mapped address, and not usable
in debuginfo.

With this fix:
  ----
  # ./perf probe -a sys_write
  Added new event:
    probe:sys_write      (on sys_write)

  You can now use it in all perf tools, such as:

          perf record -e probe:sys_write -aR sleep 1
  ----

Signed-off-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Cc: He Kuang <hekuang@huawei.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Wang Nan <wangnan0@huawei.com>
Link: http://lkml.kernel.org/r/20150322114022.32639.19096.stgit@localhost.localdomain
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/util/probe-event.c

index 6b95985db5b0faa91af0dde19cd0f41c6c69dd8d..8feac0774c41d97ec61a8a54a55afa08a84cee5a 100644 (file)
@@ -310,7 +310,10 @@ static int find_alternative_probe_point(struct debuginfo *dinfo,
 
        /* Find the address of given function */
        map__for_each_symbol_by_name(map, pp->function, sym) {
-               address = sym->start;
+               if (uprobes)
+                       address = sym->start;
+               else
+                       address = map->unmap_ip(map, sym->start);
                break;
        }
        if (!address) {