drm: mxsfb: fix error return code in mxsfb_load()
authorWei Yongjun <weiyongjun1@huawei.com>
Sun, 5 Feb 2017 16:00:36 +0000 (16:00 +0000)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Mon, 6 Feb 2017 15:57:36 +0000 (16:57 +0100)
Fix to return a negative error code from the error handling
case instead of 0, as done elsewhere in this function.

Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: http://patchwork.freedesktop.org/patch/msgid/20170205160036.7364-1-weiyj.lk@gmail.com
drivers/gpu/drm/mxsfb/mxsfb_drv.c

index cdfbe0284635decf262db79c0b048291cc87c026..28a75cb155f73b35ec4b98c26595a750fa2457e2 100644 (file)
@@ -221,6 +221,7 @@ static int mxsfb_load(struct drm_device *drm, unsigned long flags)
        mxsfb->fbdev = drm_fbdev_cma_init(drm, 32,
                                          drm->mode_config.num_connector);
        if (IS_ERR(mxsfb->fbdev)) {
+               ret = PTR_ERR(mxsfb->fbdev);
                mxsfb->fbdev = NULL;
                dev_err(drm->dev, "Failed to init FB CMA area\n");
                goto err_cma;