ath9k_hw: use a callback for frequency change
authorLuis R. Rodriguez <lrodriguez@atheros.com>
Mon, 19 Oct 2009 06:33:41 +0000 (02:33 -0400)
committerJohn W. Linville <linville@tuxdriver.com>
Fri, 30 Oct 2009 20:50:37 +0000 (16:50 -0400)
This avoids a branch on every channel change.

Signed-off-by: Luis R. Rodriguez <lrodriguez@atheros.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
drivers/net/wireless/ath/ath9k/hw.c
drivers/net/wireless/ath/ath9k/hw.h

index d4dc1cbe00aa039f25efc5059db0e64fa21e482b..f2b2f45d3a7838a3e7324a8c17fb58d4f7742f5a 100644 (file)
@@ -951,8 +951,11 @@ int ath9k_hw_init(struct ath_hw *ah)
        ath9k_hw_init_cal_settings(ah);
 
        ah->ani_function = ATH9K_ANI_ALL;
-       if (AR_SREV_9280_10_OR_LATER(ah))
+       if (AR_SREV_9280_10_OR_LATER(ah)) {
                ah->ani_function &= ~ATH9K_ANI_NOISE_IMMUNITY_LEVEL;
+               ah->ath9k_hw_rf_set_freq = &ath9k_hw_ar9280_set_channel;
+       } else
+               ah->ath9k_hw_rf_set_freq = &ath9k_hw_set_channel;
 
        ath9k_hw_init_mode_regs(ah);
 
@@ -1889,10 +1892,7 @@ static bool ath9k_hw_channel_change(struct ath_hw *ah,
 
        ath9k_hw_set_regs(ah, chan);
 
-       if (AR_SREV_9280_10_OR_LATER(ah))
-               r = ath9k_hw_ar9280_set_channel(ah, chan);
-       else
-               r = ath9k_hw_set_channel(ah, chan);
+       r = ah->ath9k_hw_rf_set_freq(ah, chan);
        if (r) {
                ath_print(common, ATH_DBG_FATAL,
                          "Failed to set channel\n");
@@ -2534,10 +2534,7 @@ int ath9k_hw_reset(struct ath_hw *ah, struct ath9k_channel *chan,
 
        REG_WRITE(ah, AR_RSSI_THR, INIT_RSSI_THR);
 
-       if (AR_SREV_9280_10_OR_LATER(ah))
-               r = ath9k_hw_ar9280_set_channel(ah, chan);
-       else
-               r = ath9k_hw_set_channel(ah, chan);
+       r = ah->ath9k_hw_rf_set_freq(ah, chan);
        if (r)
                return r;
 
index 7f2b5d21f2f13f553218e74c5e12d0ce3a7779e1..dcf1295f4eb450fbfe49e8e8b8b68da112e403d1 100644 (file)
@@ -548,7 +548,9 @@ struct ath_hw {
                DONT_USE_32KHZ,
        } enable_32kHz_clock;
 
-       /* RF */
+       /* Callback for radio frequency change */
+       int (*ath9k_hw_rf_set_freq)(struct ath_hw *ah, struct ath9k_channel *chan);
+       /* Used to program the radio on non single-chip devices */
        u32 *analogBank0Data;
        u32 *analogBank1Data;
        u32 *analogBank2Data;