ASoC: jack: Fix multiple definition of `snd_soc_jack_add_gpiods'
authorJarkko Nikula <jarkko.nikula@linux.intel.com>
Tue, 27 May 2014 07:39:57 +0000 (10:39 +0300)
committerMark Brown <broonie@linaro.org>
Tue, 27 May 2014 11:05:30 +0000 (12:05 +0100)
Commit f025d3b9c64e ("ASoC: jack: Add support for GPIO descriptor defined
jack pins") caused build error when CONFIG_GPIOLIB is not set:

sound/include/sound/soc.h:470: multiple definition of `snd_soc_jack_add_gpiods'
sound/soc/soc-core.o:sound/include/sound/soc.h:470: first defined here
make[2]: *** [sound/soc/snd-soc-core.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [sound/soc] Error 2
make: *** [sound] Error 2

Fix this by marking snd_soc_jack_add_gpiods() as static inline in soc.h.

Reported-by: kbuild test robot <fengguang.wu@intel.com>
Signed-off-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
Signed-off-by: Mark Brown <broonie@linaro.org>
include/sound/soc.h

index a2408a5b96a7de87b0cb96a85b868521f0599da6..ac21cc22c4e9135876a0138b061dcd544e1b3add 100644 (file)
@@ -465,9 +465,10 @@ static inline int snd_soc_jack_add_gpios(struct snd_soc_jack *jack, int count,
        return 0;
 }
 
-int snd_soc_jack_add_gpiods(struct device *gpiod_dev,
-                           struct snd_soc_jack *jack,
-                           int count, struct snd_soc_jack_gpio *gpios)
+static inline int snd_soc_jack_add_gpiods(struct device *gpiod_dev,
+                                         struct snd_soc_jack *jack,
+                                         int count,
+                                         struct snd_soc_jack_gpio *gpios)
 {
        return 0;
 }