intel_th: Don't leak module refcount on failure to activate
authorAlexander Shishkin <alexander.shishkin@linux.intel.com>
Fri, 24 Feb 2017 14:04:15 +0000 (16:04 +0200)
committerAlexander Shishkin <alexander.shishkin@linux.intel.com>
Wed, 15 Mar 2017 12:54:57 +0000 (14:54 +0200)
Output 'activation' may fail for the reasons of the output driver,
for example, if msc's buffer is not allocated. We forget, however,
to drop the module reference in this case. So each attempt at
activation in this case leaks a reference, preventing the module
from ever unloading.

This patch adds the missing module_put() in the activation error
path.

Signed-off-by: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: stable@vger.kernel.org # v4.8+
drivers/hwtracing/intel_th/core.c

index cdd9b3b26195aa38f03a910d10e483bca61edcca..7563eceeaaeaa3a4e70855a6d9622e960b0ab6c0 100644 (file)
@@ -221,8 +221,10 @@ static int intel_th_output_activate(struct intel_th_device *thdev)
        else
                intel_th_trace_enable(thdev);
 
-       if (ret)
+       if (ret) {
                pm_runtime_put(&thdev->dev);
+               module_put(thdrv->driver.owner);
+       }
 
        return ret;
 }