ethernet: qualcomm: QCOM_EMAC should depend on HAS_DMA and HAS_IOMEM
authorGeert Uytterhoeven <geert@linux-m68k.org>
Thu, 6 Oct 2016 14:44:53 +0000 (16:44 +0200)
committerDavid S. Miller <davem@davemloft.net>
Fri, 7 Oct 2016 01:13:03 +0000 (21:13 -0400)
If NO_DMA=y:

    drivers/built-in.o: In function `emac_probe':
    emac.c:(.text+0x3780b8): undefined reference to `bad_dma_ops'
    emac.c:(.text+0x3780e2): undefined reference to `bad_dma_ops'
    emac.c:(.text+0x378112): undefined reference to `bad_dma_ops'
    emac.c:(.text+0x378146): undefined reference to `bad_dma_ops'
    emac.c:(.text+0x37816e): undefined reference to `bad_dma_ops'
    drivers/built-in.o:emac.c:(.text+0x37819a): more undefined references to `bad_dma_ops' follow

If NO_IOMEM=y:

    drivers/net/ethernet/qualcomm/emac/emac.c: In function ‘emac_remove’:
    drivers/net/ethernet/qualcomm/emac/emac.c:736:3: error: implicit declaration of function ‘iounmap’ [-Werror=implicit-function-declaration]
       iounmap(adpt->phy.digital);
       ^

Add dependencies on HAS_DMA and HAS_IOMEM to fix this.

Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Acked-by: Timur Tabi <timur@codeaurora.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/qualcomm/Kconfig

index 9ba568db576fb0e694a2a7dd7fb945d15abf3a8d..d7720bf92d49658a4ed7a256540b4dcdc369d610 100644 (file)
@@ -26,6 +26,7 @@ config QCA7000
 
 config QCOM_EMAC
        tristate "Qualcomm Technologies, Inc. EMAC Gigabit Ethernet support"
+       depends on HAS_DMA && HAS_IOMEM
        select CRC32
        select PHYLIB
        ---help---