gpiolib: Update documentation of struct acpi_gpio_info
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Tue, 3 Jan 2017 17:01:18 +0000 (19:01 +0200)
committerLinus Walleij <linus.walleij@linaro.org>
Wed, 11 Jan 2017 11:09:36 +0000 (12:09 +0100)
It seems the code had been changed, but description left untouched.

Update description of the struct acpi_gpio_info and relative comments
accordingly.

Fixes: commit 52044723cd27 ("ACPI / gpio: Add irq_type when a GPIO is used as an interrupt")
Cc: Christophe RICARD <christophe.ricard@gmail.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/gpio/gpiolib-acpi.c
drivers/gpio/gpiolib.h

index a3faefa44f6822b6420f3f06833ba6254bee01b1..9b37a3692b3feed18578c39f4acc22ba03182e8c 100644 (file)
@@ -416,9 +416,8 @@ static int acpi_populate_gpio_lookup(struct acpi_resource *ares, void *data)
                        agpio->connection_type == ACPI_RESOURCE_GPIO_TYPE_INT;
 
                /*
-                * ActiveLow is only specified for GpioInt resource. If
-                * GpioIo is used then the only way to set the flag is
-                * to use _DSD "gpios" property.
+                * Polarity and triggering are only specified for GpioInt
+                * resource.
                 * Note: we expect here:
                 * - ACPI_ACTIVE_LOW == GPIO_ACTIVE_LOW
                 * - ACPI_ACTIVE_HIGH == GPIO_ACTIVE_HIGH
index d10eaf52086090d070b9d6c3f109e57aebf0377f..2495b7ee1b426969406b60fbb52b8a9fecae6917 100644 (file)
@@ -76,7 +76,8 @@ struct gpio_device {
 /**
  * struct acpi_gpio_info - ACPI GPIO specific information
  * @gpioint: if %true this GPIO is of type GpioInt otherwise type is GpioIo
- * @active_low: in case of @gpioint, the pin is active low
+ * @polarity: interrupt polarity as provided by ACPI
+ * @triggering: triggering type as provided by ACPI
  */
 struct acpi_gpio_info {
        bool gpioint;