iio:ad7266: Fix support for optional regulators
authorMark Brown <broonie@kernel.org>
Mon, 20 Jun 2016 12:53:33 +0000 (13:53 +0100)
committerJonathan Cameron <jic23@kernel.org>
Sun, 26 Jun 2016 16:39:00 +0000 (17:39 +0100)
The ad7266 driver attempts to support deciding between the use of internal
and external power supplies by checking to see if an error is returned when
requesting the regulator. This doesn't work with the current code since the
driver uses a normal regulator_get() which is for non-optional supplies
and so assumes that if a regulator is not provided by the platform then
this is a bug in the platform integration and so substitutes a dummy
regulator. Use regulator_get_optional() instead which indicates to the
framework that the regulator may be absent and provides a dummy regulator
instead.

Signed-off-by: Mark Brown <broonie@kernel.org>
Cc: <Stable@vger.kernel.org>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
drivers/iio/adc/ad7266.c

index 835d45db258fb7b4646cd7395664cb510a7ca0b4..655b36b4e9cb68af11bd2025840a5e1a1c7bdd5d 100644 (file)
@@ -396,7 +396,7 @@ static int ad7266_probe(struct spi_device *spi)
 
        st = iio_priv(indio_dev);
 
-       st->reg = devm_regulator_get(&spi->dev, "vref");
+       st->reg = devm_regulator_get_optional(&spi->dev, "vref");
        if (!IS_ERR(st->reg)) {
                ret = regulator_enable(st->reg);
                if (ret)