ipv6: Annotate change of locking mechanism for np->opt
authorBenjamin Poirier <bpoirier@suse.com>
Thu, 18 Feb 2016 00:20:33 +0000 (16:20 -0800)
committerDavid S. Miller <davem@davemloft.net>
Thu, 18 Feb 2016 20:27:25 +0000 (15:27 -0500)
follows up commit 45f6fad84cc3 ("ipv6: add complete rcu protection around
np->opt") which added mixed rcu/refcount protection to np->opt.

Given the current implementation of rcu_pointer_handoff(), this has no
effect at runtime.

Signed-off-by: Benjamin Poirier <bpoirier@suse.com>
Acked-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
include/net/ipv6.h

index 6570f379aba2eb744b0e8522349f0612b01b6814..f3c9857c645dee91a8a850ed5639ae5894dcff73 100644 (file)
@@ -259,8 +259,12 @@ static inline struct ipv6_txoptions *txopt_get(const struct ipv6_pinfo *np)
 
        rcu_read_lock();
        opt = rcu_dereference(np->opt);
-       if (opt && !atomic_inc_not_zero(&opt->refcnt))
-               opt = NULL;
+       if (opt) {
+               if (!atomic_inc_not_zero(&opt->refcnt))
+                       opt = NULL;
+               else
+                       opt = rcu_pointer_handoff(opt);
+       }
        rcu_read_unlock();
        return opt;
 }