s390/zcrypt: use msleep() instead of mdelay()

There is no need to busy loop and monopolize a cpu for up to ~2 seconds.
The code in question that calls mdelay() is preemptible anyway, so better
let the kernel schedule different processes than just looping and causing
unnecessary delays.

Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
Acked-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>

diff --git a/drivers/s390/crypto/ap_bus.c b/drivers/s390/crypto/ap_bus.c
index 559a9dcdb15d274d4bad423bdbef6f01da769639..d78b3d629d78dd9175736b99a2ac2a14adaf26c9 100644 (file)
--- a/drivers/s390/crypto/ap_bus.c
+++ b/drivers/s390/crypto/ap_bus.c
@@ -1372,7 +1372,7 @@ static int ap_probe_device_type(struct ap_device *ap_dev)
 
        /* Wait for the test message to complete. */
        for (i = 0; i < 6; i++) {
-               mdelay(300);
+               msleep(300);
                status = __ap_recv(ap_dev->qid, &psmid, reply, 4096);
                if (status.response_code == AP_RESPONSE_NORMAL &&
                    psmid == 0x0102030405060708ULL)

diff --git a/drivers/s390/crypto/zcrypt_pcixcc.c b/drivers/s390/crypto/zcrypt_pcixcc.c
index 899ffa19f5ecd1105e2844362d2a9eb2403b880d..f41852768953dfc6aea96316a995a7274a243ebc 100644 (file)
--- a/drivers/s390/crypto/zcrypt_pcixcc.c
+++ b/drivers/s390/crypto/zcrypt_pcixcc.c
@@ -182,7 +182,7 @@ static int zcrypt_pcixcc_mcl(struct ap_device *ap_dev)
 
        /* Wait for the test message to complete. */
        for (i = 0; i < 6; i++) {
-               mdelay(300);
+               msleep(300);
                rc = ap_recv(ap_dev->qid, &psmid, reply, 4096);
                if (rc == 0 && psmid == 0x0102030405060708ULL)
                        break;