binder: remove dead code in binder_get_ref_for_node
authorTodd Kjos <tkjos@android.com>
Thu, 29 Jun 2017 19:01:50 +0000 (12:01 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 17 Jul 2017 12:47:29 +0000 (14:47 +0200)
node is always non-NULL in binder_get_ref_for_node so the
conditional and else clause are not needed

Signed-off-by: Todd Kjos <tkjos@google.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/android/binder.c

index 3c1129d918257ad253cde152b1ae38fd5c913ce6..3bbfb2455b703c44f02611a7ca240fcc55338ec7 100644 (file)
@@ -670,18 +670,12 @@ static struct binder_ref *binder_get_ref_for_node(struct binder_proc *proc,
        }
        rb_link_node(&new_ref->rb_node_desc, parent, p);
        rb_insert_color(&new_ref->rb_node_desc, &proc->refs_by_desc);
-       if (node) {
-               hlist_add_head(&new_ref->node_entry, &node->refs);
+       hlist_add_head(&new_ref->node_entry, &node->refs);
 
-               binder_debug(BINDER_DEBUG_INTERNAL_REFS,
-                            "%d new ref %d desc %d for node %d\n",
-                             proc->pid, new_ref->debug_id, new_ref->desc,
-                             node->debug_id);
-       } else {
-               binder_debug(BINDER_DEBUG_INTERNAL_REFS,
-                            "%d new ref %d desc %d for dead node\n",
-                             proc->pid, new_ref->debug_id, new_ref->desc);
-       }
+       binder_debug(BINDER_DEBUG_INTERNAL_REFS,
+                    "%d new ref %d desc %d for node %d\n",
+                     proc->pid, new_ref->debug_id, new_ref->desc,
+                     node->debug_id);
        return new_ref;
 }