[SCSI] scsi:hosts.c Fix warning: variable 'rval' set but not used
authorJustin P. Mattock <justinmattock@gmail.com>
Fri, 18 Jun 2010 20:16:07 +0000 (13:16 -0700)
committerJames Bottomley <James.Bottomley@suse.de>
Tue, 27 Jul 2010 17:03:51 +0000 (12:03 -0500)
The below patch fixes a warning message generated by gcc 4.6.0
  CC      drivers/scsi/hosts.o
drivers/scsi/hosts.c: In function 'scsi_host_alloc':
drivers/scsi/hosts.c:328:6: warning: variable 'rval' set but not used

Fix this by removing the rval but placing a printk warning where it
would have been set.

Signed-off-by: Justin P. Mattock <justinmattock@gmail.com>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
drivers/scsi/hosts.c

index 6660fa92ffa149a3419ca3c87f7744453e3706fb..a2b1414da288feb1b2085c9848d7e4fe64432eb2 100644 (file)
@@ -325,7 +325,6 @@ struct Scsi_Host *scsi_host_alloc(struct scsi_host_template *sht, int privsize)
 {
        struct Scsi_Host *shost;
        gfp_t gfp_mask = GFP_KERNEL;
-       int rval;
 
        if (sht->unchecked_isa_dma && privsize)
                gfp_mask |= __GFP_DMA;
@@ -420,7 +419,8 @@ struct Scsi_Host *scsi_host_alloc(struct scsi_host_template *sht, int privsize)
        shost->ehandler = kthread_run(scsi_error_handler, shost,
                        "scsi_eh_%d", shost->host_no);
        if (IS_ERR(shost->ehandler)) {
-               rval = PTR_ERR(shost->ehandler);
+               printk(KERN_WARNING "scsi%d: error handler thread failed to spawn, error = %ld\n",
+                       shost->host_no, PTR_ERR(shost->ehandler));
                goto fail_kfree;
        }