ASoC: mxs-saif: Handle errors for clk_enable
authorJiasheng Jiang <jiasheng@iscas.ac.cn>
Tue, 1 Mar 2022 08:17:17 +0000 (16:17 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 20 Apr 2022 07:08:15 +0000 (09:08 +0200)
[ Upstream commit 2ecf362d220317debf5da376e0390e9f7a3f7b29 ]

As the potential failure of the clk_enable(),
it should be better to check it, like mxs_saif_trigger().

Fixes: d0ba4c014934 ("ASoC: mxs-saif: set a base clock rate for EXTMASTER mode work")
Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
Link: https://lore.kernel.org/r/20220301081717.3727190-1-jiasheng@iscas.ac.cn
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
sound/soc/mxs/mxs-saif.c

index 156aa7c00787860b1f26267ffcf4267601433acf..93c0196701998351d730a7964d4d6ca331309668 100644 (file)
@@ -467,7 +467,10 @@ static int mxs_saif_hw_params(struct snd_pcm_substream *substream,
                * basic clock which should be fast enough for the internal
                * logic.
                */
-               clk_enable(saif->clk);
+               ret = clk_enable(saif->clk);
+               if (ret)
+                       return ret;
+
                ret = clk_set_rate(saif->clk, 24000000);
                clk_disable(saif->clk);
                if (ret)