power:bq27xxx: 27000/10 read FLAGS register as single
authorH. Nikolaus Schaller <hns@goldelico.com>
Mon, 18 Jul 2016 16:12:09 +0000 (18:12 +0200)
committerSebastian Reichel <sre@kernel.org>
Mon, 15 Aug 2016 19:26:52 +0000 (21:26 +0200)
The bq27000 and bq27010 have a single byte FLAGS register.
Other gauges have 16 bit FLAGS registers.

For reading the FLAGS register it is sufficient to read the single
register instead of reading RSOC at the next higher address as
well and then ignore the high byte.

This does not change functionality but optimizes i2c and hdq
traffic.

Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
Acked-by: Pali Rohár <pali.rohar@gmail.com>
Acked-by: Andrew F. Davis <afd@ti.com>
Signed-off-by: Sebastian Reichel <sre@kernel.org>
drivers/power/supply/bq27xxx_battery.c

index 323d05a12f9b80fc855286d74a9b0e72021d1a03..3f57dd54803a51b7c209aeb68cc39d746ec2279e 100644 (file)
@@ -644,8 +644,9 @@ static bool bq27xxx_battery_dead(struct bq27xxx_device_info *di, u16 flags)
 static int bq27xxx_battery_read_health(struct bq27xxx_device_info *di)
 {
        int flags;
+       bool has_singe_flag = di->chip == BQ27000 || di->chip == BQ27010;
 
-       flags = bq27xxx_read(di, BQ27XXX_REG_FLAGS, false);
+       flags = bq27xxx_read(di, BQ27XXX_REG_FLAGS, has_singe_flag);
        if (flags < 0) {
                dev_err(di->dev, "error reading flag register:%d\n", flags);
                return flags;
@@ -745,7 +746,7 @@ static int bq27xxx_battery_current(struct bq27xxx_device_info *di,
        }
 
        if (di->chip == BQ27000 || di->chip == BQ27010) {
-               flags = bq27xxx_read(di, BQ27XXX_REG_FLAGS, false);
+               flags = bq27xxx_read(di, BQ27XXX_REG_FLAGS, true);
                if (flags & BQ27000_FLAG_CHGS) {
                        dev_dbg(di->dev, "negative current!\n");
                        curr = -curr;