drm/radeon: Don't unreserve twice on failure to validate.
authorMichel Dänzer <daenzer@vmware.com>
Tue, 28 Jul 2009 10:30:55 +0000 (12:30 +0200)
committerDave Airlie <airlied@redhat.com>
Wed, 29 Jul 2009 05:45:37 +0000 (15:45 +1000)
This is done later in radeon_object_list_unvalidate(). Doing it twice triggers
a BUG in TTM, rendering X on KMS unusable until reboot.

Signed-off-by: Michel Dänzer <daenzer@vmware.com>
Signed-off-by: Dave Airlie <airlied@redhat.com>
drivers/gpu/drm/radeon/radeon_object.c

index d5b1fd562d88c6a5eec3090ee738e78036cedbc1..3961a44c5dce784c47e77fd8ae3fb9bf9d61ec07 100644 (file)
@@ -433,7 +433,6 @@ int radeon_object_list_validate(struct list_head *head, void *fence)
                                                       robj->tobj.proposed_placement,
                                                       true, false);
                        if (unlikely(r)) {
-                               radeon_object_list_unreserve(head);
                                DRM_ERROR("radeon: failed to validate.\n");
                                return r;
                        }