[PATCH] ALPS: fix enabling hardware tapping
authorDmitry Torokhov <dtor_core@ameritech.net>
Thu, 16 Jun 2005 05:26:36 +0000 (22:26 -0700)
committerLinus Torvalds <torvalds@ppc970.osdl.org>
Thu, 16 Jun 2005 16:02:59 +0000 (09:02 -0700)
It looks like logic for enabling hardware tapping in ALPS driver was
inverted and we enable it only if it was already enabled by BIOS or
firmware.

I have a confirmation from one user that the patch below fixes the problem
for him and it might be beneficial if we could get it into 2.6.12.

Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
drivers/input/mouse/alps.c

index 42a9f7f6f8cb2a9b31e65404959dfbb1305be942..7bf4be733e9a89f6646ccf979503d8e4797e4400 100644 (file)
@@ -352,7 +352,7 @@ static int alps_reconnect(struct psmouse *psmouse)
        if (alps_get_status(psmouse, param))
                return -1;
 
-       if (param[0] & 0x04)
+       if (!(param[0] & 0x04))
                alps_tap_mode(psmouse, 1);
 
        if (alps_absolute_mode(psmouse)) {