staging: comedi: 8255: use pointer to dev->subdevices
authorH Hartley Sweeten <hartleys@visionengravers.com>
Wed, 13 Jun 2012 22:41:27 +0000 (15:41 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 14 Jun 2012 00:19:08 +0000 (17:19 -0700)
Instead of accessing the dev->subdevices directly as an array,
use a pointer. This method is more common in the comedi subsystem.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/comedi/drivers/8255.c

index b608a05bcd1b927513a16dc716d9a5fac7f54fda..23b9accc34d33fd4408e75ba0668a2cff473d226 100644 (file)
@@ -371,6 +371,7 @@ EXPORT_SYMBOL(subdev_8255_cleanup);
 static int dev_8255_attach(struct comedi_device *dev,
                           struct comedi_devconfig *it)
 {
+       struct comedi_subdevice *s;
        int ret;
        unsigned long iobase;
        int i;
@@ -392,16 +393,16 @@ static int dev_8255_attach(struct comedi_device *dev,
                return ret;
 
        for (i = 0; i < dev->n_subdevices; i++) {
+               s = dev->subdevices + i;
                iobase = it->options[i];
 
                if (!request_region(iobase, _8255_SIZE, "8255")) {
                        dev_warn(dev->class_dev,
                                "0x%04lx (I/O port conflict)\n", iobase);
 
-                       dev->subdevices[i].type = COMEDI_SUBD_UNUSED;
+                       s->type = COMEDI_SUBD_UNUSED;
                } else {
-                       subdev_8255_init(dev, dev->subdevices + i, NULL,
-                                        iobase);
+                       subdev_8255_init(dev, s, NULL, iobase);
                        dev_info(dev->class_dev, "0x%04lx\n", iobase);
                }
        }