iwlwifi: mvm: check if returned value is NULL

While freeing inactive queue, check mvmsta to be valid before
dereferencing it.  Found by Klocwork.

Signed-off-by: Sharon Dvir <sharon.dvir@intel.com>
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>

diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/sta.c b/drivers/net/wireless/intel/iwlwifi/mvm/sta.c
index a2a1fa06b78146344e6b723124acba53db955eb9..fc6d854b04b6f4de7b5842a96e911b0a1060b27b 100644 (file)
--- a/drivers/net/wireless/intel/iwlwifi/mvm/sta.c
+++ b/drivers/net/wireless/intel/iwlwifi/mvm/sta.c
@@ -495,6 +495,8 @@ static int iwl_mvm_free_inactive_queue(struct iwl_mvm *mvm, int queue,
        spin_unlock_bh(&mvm->queue_info_lock);
 
        mvmsta = iwl_mvm_sta_from_staid_protected(mvm, sta_id);
+       if (WARN_ON(!mvmsta))
+               return -EINVAL;
 
        disable_agg_tids = iwl_mvm_remove_sta_queue_marking(mvm, queue);
        /* Disable the queue */