PCI: layerscape: Simplify platform_get_resource_byname() failure checking
authorBjorn Helgaas <bhelgaas@google.com>
Thu, 9 Apr 2015 19:36:52 +0000 (14:36 -0500)
committerBjorn Helgaas <bhelgaas@google.com>
Thu, 9 Apr 2015 19:36:52 +0000 (14:36 -0500)
devm_ioremap_resource() validates the resource it receives, so if we check
for devm_ioremap_resource() failure, we need not check for failure of the
preceding platform_get_resource().

Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
drivers/pci/host/pci-layerscape.c

index 68c9e5e9b0a896edf0492e8588dddf873e22e38f..4a6e62f67579807476ae973006855d28cbfab0d6 100644 (file)
@@ -127,14 +127,11 @@ static int __init ls_pcie_probe(struct platform_device *pdev)
        pcie->dev = &pdev->dev;
 
        dbi_base = platform_get_resource_byname(pdev, IORESOURCE_MEM, "regs");
-       if (!dbi_base) {
-               dev_err(&pdev->dev, "missing *regs* space\n");
-               return -ENODEV;
-       }
-
        pcie->dbi = devm_ioremap_resource(&pdev->dev, dbi_base);
-       if (IS_ERR(pcie->dbi))
+       if (IS_ERR(pcie->dbi)) {
+               dev_err(&pdev->dev, "missing *regs* space\n");
                return PTR_ERR(pcie->dbi);
+       }
 
        pcie->scfg = syscon_regmap_lookup_by_phandle(pdev->dev.of_node,
                                                     "fsl,pcie-scfg");