hwmon: (lm75) Make the writing to sysfs more robust
authorShubhrajyoti D <shubhrajyoti@ti.com>
Thu, 28 Oct 2010 18:31:44 +0000 (20:31 +0200)
committerJean Delvare <khali@endymion.delvare>
Thu, 28 Oct 2010 18:31:44 +0000 (20:31 +0200)
Currently we get the checkpatch warning
consider using strict_strtol in preference to simple_strtol.
Also we should not allow any partially numeric values.

Signed-off-by: Shubhrajyoti D <shubhrajyoti@ti.com>
Signed-off-by: Jean Delvare <khali@linux-fr.org>
drivers/hwmon/lm75.c

index ab5b87a8167711303bc2aa8a3f107f7b86af798a..5cb79d94a990bf8ad3e85e8b1b9b7a580feda514 100644 (file)
@@ -103,7 +103,12 @@ static ssize_t set_temp(struct device *dev, struct device_attribute *da,
        struct i2c_client *client = to_i2c_client(dev);
        struct lm75_data *data = i2c_get_clientdata(client);
        int nr = attr->index;
-       long temp = simple_strtol(buf, NULL, 10);
+       long temp;
+       int error;
+
+       error = strict_strtol(buf, 10, &temp);
+       if (error)
+               return error;
 
        mutex_lock(&data->update_lock);
        data->temp[nr] = LM75_TEMP_TO_REG(temp);