ext3: remove extra IS_RDONLY() check
authorDave Hansen <haveblue@us.ibm.com>
Mon, 16 Jul 2007 06:41:14 +0000 (23:41 -0700)
committerLinus Torvalds <torvalds@woody.linux-foundation.org>
Mon, 16 Jul 2007 16:05:48 +0000 (09:05 -0700)
ext3_change_inode_journal_flag() is only called from one location:
ext3_ioctl(EXT3_IOC_SETFLAGS).  That ioctl case already has a IS_RDONLY()
call in it so this one is superfluous.

Signed-off-by: Dave Hansen <haveblue@us.ibm.com>
Cc: <linux-ext4@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
fs/ext3/inode.c

index 2a85ddee4740b1d0bf292ca71cc80c5ee2b3b71e..de4e3161e4799741b8471f699d2e38d6ddfde755 100644 (file)
@@ -3195,7 +3195,7 @@ int ext3_change_inode_journal_flag(struct inode *inode, int val)
         */
 
        journal = EXT3_JOURNAL(inode);
-       if (is_journal_aborted(journal) || IS_RDONLY(inode))
+       if (is_journal_aborted(journal))
                return -EROFS;
 
        journal_lock_updates(journal);