gpio: constify gpio_chip structures
authorJulia Lawall <Julia.Lawall@lip6.fr>
Sun, 11 Sep 2016 12:14:37 +0000 (14:14 +0200)
committerLinus Walleij <linus.walleij@linaro.org>
Tue, 13 Sep 2016 08:35:56 +0000 (10:35 +0200)
These structures are only used to copy into other structures, so declare
them as const.

The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@r disable optional_qualifier@
identifier i;
position p;
@@
static struct gpio_chip i@p = { ... };

@ok@
identifier r.i;
expression e;
position p;
@@
e = i@p;

@bad@
position p != {r.p,ok.p};
identifier r.i;
struct gpio_chip e;
@@
e@i@p

@depends on !bad disable optional_qualifier@
identifier r.i;
@@
static
+const
 struct gpio_chip i = { ... };
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Acked-by: Joachim Eastwood <manabian@gmail.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
20 files changed:
drivers/gpio/gpio-arizona.c
drivers/gpio/gpio-bcm-kona.c
drivers/gpio/gpio-da9052.c
drivers/gpio/gpio-da9055.c
drivers/gpio/gpio-it87.c
drivers/gpio/gpio-lp873x.c
drivers/gpio/gpio-lpc18xx.c
drivers/gpio/gpio-pisosr.c
drivers/gpio/gpio-sch.c
drivers/gpio/gpio-stmpe.c
drivers/gpio/gpio-tc3589x.c
drivers/gpio/gpio-tpic2810.c
drivers/gpio/gpio-tps65086.c
drivers/gpio/gpio-tps65218.c
drivers/gpio/gpio-tps65912.c
drivers/gpio/gpio-ts4900.c
drivers/gpio/gpio-twl4030.c
drivers/gpio/gpio-wm831x.c
drivers/gpio/gpio-wm8350.c
drivers/gpio/gpio-wm8994.c

index 991370494922b1f7ac3489dc0616793be319378a..482462889c8f18d05e557f2aa0616e587af6ba27 100644 (file)
@@ -79,7 +79,7 @@ static void arizona_gpio_set(struct gpio_chip *chip, unsigned offset, int value)
                           ARIZONA_GPN_LVL, value);
 }
 
-static struct gpio_chip template_chip = {
+static const struct gpio_chip template_chip = {
        .label                  = "arizona",
        .owner                  = THIS_MODULE,
        .direction_input        = arizona_gpio_direction_in,
index 953e4b829e32b8aa02f0cdb0774f8fe8244ef565..3d1cf018e8e7e27c8d7baf06a9755c7ae6a5e429 100644 (file)
@@ -308,7 +308,7 @@ static int bcm_kona_gpio_set_debounce(struct gpio_chip *chip, unsigned gpio,
        return 0;
 }
 
-static struct gpio_chip template_chip = {
+static const struct gpio_chip template_chip = {
        .label = "bcm-kona-gpio",
        .owner = THIS_MODULE,
        .request = bcm_kona_gpio_request,
index e29553b7ccdb8aaad14d574e5b6fcc433e094bb5..dd8977cf3e854fae4259d01e89a1bbf62e0b3ff2 100644 (file)
@@ -184,7 +184,7 @@ static int da9052_gpio_to_irq(struct gpio_chip *gc, u32 offset)
        return irq;
 }
 
-static struct gpio_chip reference_gp = {
+static const struct gpio_chip reference_gp = {
        .label = "da9052-gpio",
        .owner = THIS_MODULE,
        .get = da9052_gpio_get,
index 2c2c18dc6c4f394d4bce5ac675d9ca45a37e9a9d..82053b52cba03d7cb998ca4ed38f3b243b255c7a 100644 (file)
@@ -121,7 +121,7 @@ static int da9055_gpio_to_irq(struct gpio_chip *gc, u32 offset)
                                  DA9055_IRQ_GPI0 + offset);
 }
 
-static struct gpio_chip reference_gp = {
+static const struct gpio_chip reference_gp = {
        .label = "da9055-gpio",
        .owner = THIS_MODULE,
        .get = da9055_gpio_get,
index 63a962d18cd6d732af48be3849ca2d658d9bea9b..45d29e488dbb9c7371f207c20b248d06a805db89 100644 (file)
@@ -273,7 +273,7 @@ exit:
        return rc;
 }
 
-static struct gpio_chip it87_template_chip = {
+static const struct gpio_chip it87_template_chip = {
        .label                  = KBUILD_MODNAME,
        .owner                  = THIS_MODULE,
        .request                = it87_gpio_request,
index 2386b0f410fa9594a9e32949b430ea439244b80d..218c706359aaf2ea9cdd706816facf2df7aeafa6 100644 (file)
@@ -124,7 +124,7 @@ static int lp873x_gpio_set_single_ended(struct gpio_chip *gc,
        }
 }
 
-static struct gpio_chip template_chip = {
+static const struct gpio_chip template_chip = {
        .label                  = "lp873x-gpio",
        .owner                  = THIS_MODULE,
        .request                = lp873x_gpio_request,
index 98832c9f614a26e59e78aee6509a92506e1d3115..f12e02e1016d856250dc5f07521d50ef6b4516ec 100644 (file)
@@ -78,7 +78,7 @@ static int lpc18xx_gpio_direction_output(struct gpio_chip *chip,
        return lpc18xx_gpio_direction(chip, offset, true);
 }
 
-static struct gpio_chip lpc18xx_chip = {
+static const struct gpio_chip lpc18xx_chip = {
        .label                  = "lpc18xx/43xx-gpio",
        .request                = gpiochip_generic_request,
        .free                   = gpiochip_generic_free,
index cb14b8d1d5120e1535dcef462c1cc041c8a50f2a..f5545049c187e493e427fc82a8174873a5b3bbd8 100644 (file)
@@ -90,7 +90,7 @@ static int pisosr_gpio_get(struct gpio_chip *chip, unsigned offset)
        return (gpio->buffer[offset / 8] >> (offset % 8)) & 0x1;
 }
 
-static struct gpio_chip template_chip = {
+static const struct gpio_chip template_chip = {
        .label                  = "pisosr-gpio",
        .owner                  = THIS_MODULE,
        .get_direction          = pisosr_gpio_get_direction,
index eb43ae4835c15d8a65ac8f4fde2de07c7b6e19ee..54500444584626926a8ec258c09e7170ae413d4d 100644 (file)
@@ -138,7 +138,7 @@ static int sch_gpio_direction_out(struct gpio_chip *gc, unsigned gpio_num,
        return 0;
 }
 
-static struct gpio_chip sch_gpio_chip = {
+static const struct gpio_chip sch_gpio_chip = {
        .label                  = "sch_gpio",
        .owner                  = THIS_MODULE,
        .direction_input        = sch_gpio_direction_in,
index 5c0d8189a304351b469b097043c8e224fb1be3b7..b51c5be55c3a2848376eb8a8b596230c725dcec8 100644 (file)
@@ -121,7 +121,7 @@ static int stmpe_gpio_request(struct gpio_chip *chip, unsigned offset)
        return stmpe_set_altfunc(stmpe, 1 << offset, STMPE_BLOCK_GPIO);
 }
 
-static struct gpio_chip template_chip = {
+static const struct gpio_chip template_chip = {
        .label                  = "stmpe",
        .owner                  = THIS_MODULE,
        .get_direction          = stmpe_gpio_get_direction,
index 8b3659352e495b02843187b75679406469a06611..5baa45768ec543c9b45aa355c823cf07a9eb46f7 100644 (file)
@@ -124,7 +124,7 @@ static int tc3589x_gpio_single_ended(struct gpio_chip *chip,
        return -ENOTSUPP;
 }
 
-static struct gpio_chip template_chip = {
+static const struct gpio_chip template_chip = {
        .label                  = "tc3589x",
        .owner                  = THIS_MODULE,
        .direction_input        = tc3589x_gpio_direction_input,
index cace79c1b70a53fa9d339d4e7902abfe627a690b..c8b34d787eedeb27fa6315cba34ea9b286cf9c59 100644 (file)
@@ -87,7 +87,7 @@ static void tpic2810_set_multiple(struct gpio_chip *chip, unsigned long *mask,
        tpic2810_set_mask_bits(chip, *mask, *bits);
 }
 
-static struct gpio_chip template_chip = {
+static const struct gpio_chip template_chip = {
        .label                  = "tpic2810",
        .owner                  = THIS_MODULE,
        .get_direction          = tpic2810_get_direction,
index 8e25f01ac314c3e0a7970e62f0881b8851fccb5e..b23c4d2429be51f47035f1920554e3bf77e122ae 100644 (file)
@@ -72,7 +72,7 @@ static void tps65086_gpio_set(struct gpio_chip *chip, unsigned offset,
                           BIT(4 + offset), value ? BIT(4 + offset) : 0);
 }
 
-static struct gpio_chip template_chip = {
+static const struct gpio_chip template_chip = {
        .label                  = "tps65086-gpio",
        .owner                  = THIS_MODULE,
        .get_direction          = tps65086_gpio_get_direction,
index 1c09a19ae10c26c583551f500c0926cb2a53a71e..03e0dfbe9720585ba04974a843fa3da8cb89c930 100644 (file)
@@ -172,7 +172,7 @@ static int tps65218_gpio_set_single_ended(struct gpio_chip *gc,
        return -ENOTSUPP;
 }
 
-static struct gpio_chip template_chip = {
+static const struct gpio_chip template_chip = {
        .label                  = "gpio-tps65218",
        .owner                  = THIS_MODULE,
        .request                = tps65218_gpio_request,
index acfd30a13a567902571c531ae5ac8052d0863375..abc0798ef843a485a88b4a520cb529e1b6b99780 100644 (file)
@@ -90,7 +90,7 @@ static void tps65912_gpio_set(struct gpio_chip *gc, unsigned offset,
                           GPIO_SET_MASK, value ? GPIO_SET_MASK : 0);
 }
 
-static struct gpio_chip template_chip = {
+static const struct gpio_chip template_chip = {
        .label                  = "tps65912-gpio",
        .owner                  = THIS_MODULE,
        .get_direction          = tps65912_gpio_get_direction,
index 9dd9aca820e745b6fce1afe7ca212fc0427cd2fe..5bd21725e6043db85583b6dbf5344dcdd12810c8 100644 (file)
@@ -101,7 +101,7 @@ static const struct regmap_config ts4900_regmap_config = {
        .val_bits = 8,
 };
 
-static struct gpio_chip template_chip = {
+static const struct gpio_chip template_chip = {
        .label                  = "ts4900-gpio",
        .owner                  = THIS_MODULE,
        .get_direction          = ts4900_gpio_get_direction,
index 4b807b0e0c8e1696f8e9c80fec355eb72744aceb..dfcfbba74416016c6bc4a936b4072dc4cd9bec00 100644 (file)
@@ -381,7 +381,7 @@ static int twl_to_irq(struct gpio_chip *chip, unsigned offset)
                : -EINVAL;
 }
 
-static struct gpio_chip template_chip = {
+static const struct gpio_chip template_chip = {
        .label                  = "twl4030",
        .owner                  = THIS_MODULE,
        .request                = twl_request,
index 21f97bcd0062c2fccfccae1971d1bce1b15352a6..533707f943f44fd9890f5738149d65d96f34d856 100644 (file)
@@ -247,7 +247,7 @@ static void wm831x_gpio_dbg_show(struct seq_file *s, struct gpio_chip *chip)
 #define wm831x_gpio_dbg_show NULL
 #endif
 
-static struct gpio_chip template_chip = {
+static const struct gpio_chip template_chip = {
        .label                  = "wm831x",
        .owner                  = THIS_MODULE,
        .direction_input        = wm831x_gpio_direction_in,
index e9765707d5c1f255c159300cbc2e456508eb37e3..e46752e73dd9066e91d9c9edb55bc15ef0ae02ec 100644 (file)
@@ -93,7 +93,7 @@ static int wm8350_gpio_to_irq(struct gpio_chip *chip, unsigned offset)
        return wm8350->irq_base + WM8350_IRQ_GPIO(offset);
 }
 
-static struct gpio_chip template_chip = {
+static const struct gpio_chip template_chip = {
        .label                  = "wm8350",
        .owner                  = THIS_MODULE,
        .direction_input        = wm8350_gpio_direction_in,
index 2457aac8592e7c7f1fd73d6300944281b9715313..68410fda61383214cb5328645fcb71e237bece7c 100644 (file)
@@ -249,7 +249,7 @@ static void wm8994_gpio_dbg_show(struct seq_file *s, struct gpio_chip *chip)
 #define wm8994_gpio_dbg_show NULL
 #endif
 
-static struct gpio_chip template_chip = {
+static const struct gpio_chip template_chip = {
        .label                  = "wm8994",
        .owner                  = THIS_MODULE,
        .request                = wm8994_gpio_request,