clk: qoriq: fix refcount leak in clockgen_init()
authorYangtao Li <tiny.windzz@gmail.com>
Wed, 26 Dec 2018 13:14:42 +0000 (08:14 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 29 Jan 2020 09:24:07 +0000 (10:24 +0100)
[ Upstream commit 70af6c5b5270e8101f318c4b69cc98a726edfab9 ]

The of_find_compatible_node() returns a node pointer with refcount
incremented, but there is the lack of use of the of_node_put() when
done. Add the missing of_node_put() to release the refcount.

Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
Fixes: 0dfc86b3173f ("clk: qoriq: Move chip-specific knowledge into driver")
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/clk/clk-qoriq.c

index cdce49f6476aaa8516bef9d371b75158d0342c05..65876ff6df4114732594155a8d32ad9ced781bcc 100644 (file)
@@ -1245,6 +1245,7 @@ static void __init clockgen_init(struct device_node *np)
                                pr_err("%s: Couldn't map %s regs\n", __func__,
                                       guts->full_name);
                        }
+                       of_node_put(guts);
                }
 
        }