drm/i915: Remove redundant queue_delayed_work() from throttle ioctl
authorChris Wilson <chris@chris-wilson.co.uk>
Mon, 4 Jul 2016 07:08:33 +0000 (08:08 +0100)
committerChris Wilson <chris@chris-wilson.co.uk>
Mon, 4 Jul 2016 07:18:21 +0000 (08:18 +0100)
We know, by design, that whilst the GPU is active (and thus we are
throttling) the retire_worker is queued. Therefore attempting to requeue
it with queue_delayed_work() is a no-op and we can safely remove it.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Link: http://patchwork.freedesktop.org/patch/msgid/1467616119-4093-3-git-send-email-chris@chris-wilson.co.uk
drivers/gpu/drm/i915/i915_gem.c

index 78057fafd4bc36f8f0988735733bcc3ef4efc8b6..e6675b981e0e55ad99a6a06c983a95dd3c1f1eb1 100644 (file)
@@ -4467,9 +4467,6 @@ i915_gem_ring_throttle(struct drm_device *dev, struct drm_file *file)
                return 0;
 
        ret = __i915_wait_request(target, true, NULL, NULL);
-       if (ret == 0)
-               queue_delayed_work(dev_priv->wq, &dev_priv->gt.retire_work, 0);
-
        i915_gem_request_unreference(target);
 
        return ret;