gpio: make the iterator point to last handle

When initializing the GPIO handles, we use the iterator (i)
to back off if something goes wrong. But since the iterator
is also used after we pass the loop, we must decrement by
one after exiting the loop so that we point at the last
element in the array.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Walter Harms <wharms@bfs.de>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
index c826844abdebe91ea39b3c75a88d060f207b38f0..b504364fd6444dfaf172125ce175c3230ce7343d 100644 (file)
--- a/drivers/gpio/gpiolib.c
+++ b/drivers/gpio/gpiolib.c
@@ -474,6 +474,8 @@ static int linehandle_create(struct gpio_device *gdev, void __user *ip)
                dev_dbg(&gdev->dev, "registered chardev handle for line %d\n",
                        offset);
        }
+       /* Let i point at the last handle */
+       i--;
        lh->numdescs = handlereq.lines;
 
        fd = anon_inode_getfd("gpio-linehandle",