auditsc: remove audit_set_context() altogether - fold it into its caller
authorAndrew Morton <akpm@linux-foundation.org>
Mon, 8 Apr 2013 21:43:41 +0000 (14:43 -0700)
committerEric Paris <eparis@redhat.com>
Wed, 10 Apr 2013 19:18:50 +0000 (15:18 -0400)
>   In function audit_alloc_context(), use kzalloc, instead of kmalloc+memset. Patch also renames audit_zero_context() to
> audit_set_context(), to represent it's inner workings properly.

Fair enough.  I'd go futher...

Cc: Al Viro <viro@zeniv.linux.org.uk>
Cc: Eric Paris <eparis@redhat.com>
Cc: Rakib Mullick <rakib.mullick@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Eric Paris <eparis@redhat.com>
kernel/auditsc.c

index 9dc3bae9793d27b4eb13d29561e1adecdd09d8e5..b536d22fe56f2540926c2a7a84593d446176e24e 100644 (file)
@@ -1048,13 +1048,6 @@ static inline void audit_free_aux(struct audit_context *context)
        }
 }
 
-static inline void audit_set_context(struct audit_context *context,
-                                     enum audit_state state)
-{
-       context->state      = state;
-       context->prio = state == AUDIT_RECORD_CONTEXT ? ~0ULL : 0;
-}
-
 static inline struct audit_context *audit_alloc_context(enum audit_state state)
 {
        struct audit_context *context;
@@ -1062,7 +1055,8 @@ static inline struct audit_context *audit_alloc_context(enum audit_state state)
        context = kzalloc(sizeof(*context), GFP_KERNEL);
        if (!context)
                return NULL;
-       audit_set_context(context, state);
+       context->state = state;
+       context->prio = state == AUDIT_RECORD_CONTEXT ? ~0ULL : 0;
        INIT_LIST_HEAD(&context->killed_trees);
        INIT_LIST_HEAD(&context->names_list);
        return context;