[media] v4l: omap4iss: Clean up file handle in open() and release()
authorShailendra Verma <shailendra.v@samsung.com>
Fri, 25 Nov 2016 04:49:14 +0000 (02:49 -0200)
committerMauro Carvalho Chehab <mchehab@s-opensource.com>
Tue, 31 Jan 2017 13:50:06 +0000 (11:50 -0200)
Both functions initialize the file handle with v4l2_fh_init() and thus
need to call clean up with v4l2_fh_exit() as appropriate. Fix it.

Signed-off-by: Shailendra Verma <shailendra.v@samsung.com>
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
drivers/staging/media/omap4iss/iss_video.c

index f4b0e660109fffa832ae5a74105256a07dfade6c..bb0e3b4a4558ab6f69da99891c77cadc634681a0 100644 (file)
@@ -1141,6 +1141,7 @@ static int iss_video_open(struct file *file)
 done:
        if (ret < 0) {
                v4l2_fh_del(&handle->vfh);
+               v4l2_fh_exit(&handle->vfh);
                kfree(handle);
        }
 
@@ -1162,6 +1163,7 @@ static int iss_video_release(struct file *file)
        vb2_queue_release(&handle->queue);
 
        v4l2_fh_del(vfh);
+       v4l2_fh_exit(vfh);
        kfree(handle);
        file->private_data = NULL;