projects / GitHub / moto-9609 / android_kernel_motorola_exynos9610.git / commitdiff
? search:
summary | shortlog | log | commit | commitdiff | tree
raw | patch | inline | side by side (parent: 9b0f258)
USB: serial: Note mos7480 and option don't lock modem status
authorAlan Cox <alan@lxorguk.ukuu.org.uk>
Wed, 20 Feb 2008 20:51:45 +0000 (20:51 +0000)
committerGreg Kroah-Hartman <gregkh@suse.de>
Fri, 25 Apr 2008 04:16:39 +0000 (21:16 -0700)
Signed-off-by: Alan Cox <alan@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/usb/serial/mos7840.c patch | blob | blame | history
drivers/usb/serial/option.c patch | blob | blame | history

diff --git a/drivers/usb/serial/mos7840.c b/drivers/usb/serial/mos7840.c
index aeeb9cb209994d5a2f0a17c925509605c84d1184..0b29c5383dc8800adb9a5684a63fea24195cfa23 100644 (file)
--- a/drivers/usb/serial/mos7840.c
+++ b/drivers/usb/serial/mos7840.c
@@ -1722,6 +1722,7 @@ static int mos7840_tiocmset(struct usb_serial_port *port, struct file *file,
        if (mos7840_port == NULL)
                return -ENODEV;
 
+       /* FIXME: What locks the port registers ? */
        mcr = mos7840_port->shadowMCR;
        if (clear & TIOCM_RTS)
                mcr &= ~MCR_RTS;
diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
index d101025a4c637176a0503e5c71a0079700fc7e9a..0e7eeb2820e2ceec558759102ad72b10ff4c0f95 100644 (file)
--- a/drivers/usb/serial/option.c
+++ b/drivers/usb/serial/option.c
@@ -458,6 +458,7 @@ static int option_tiocmset(struct usb_serial_port *port, struct file *file,
 
        portdata = usb_get_serial_port_data(port);
 
+       /* FIXME: what locks portdata fields ? */
        if (set & TIOCM_RTS)
                portdata->rts_state = 1;
        if (set & TIOCM_DTR)