thermal/drivers/hisi: Remove pointless lock

commit 2d4fa7b4c6f8080ced2e8237c9f46fb1fc110d64 upstream.

The threaded interrupt inspect the sensors structure to look in the temp
threshold field, but this field is read-only in all the code, except in the
probe function before the threaded interrupt is set. In other words there
is not race window in the threaded interrupt when reading the field value.

Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Reviewed-by: Leo Yan <leo.yan@linaro.org>
Signed-off-by: Eduardo Valentin <edubezval@gmail.com>
Signed-off-by: Rafael David Tinoco <rafael.tinoco@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/thermal/hisi_thermal.c b/drivers/thermal/hisi_thermal.c
index aecbfe9fc8f23675a0f2859260928d8f5c962cf8..0c2966c285b150ec1f68f327673bedaaaef84899 100644 (file)
--- a/drivers/thermal/hisi_thermal.c
+++ b/drivers/thermal/hisi_thermal.c
@@ -221,14 +221,10 @@ static irqreturn_t hisi_thermal_alarm_irq(int irq, void *dev)
 static irqreturn_t hisi_thermal_alarm_irq_thread(int irq, void *dev)
 {
        struct hisi_thermal_data *data = dev;
-       struct hisi_thermal_sensor *sensor;
-
-       mutex_lock(&data->thermal_lock);
-       sensor = &data->sensors;
+       struct hisi_thermal_sensor *sensor = &data->sensors;
 
        dev_crit(&data->pdev->dev, "THERMAL ALARM: T > %d\n",
                 sensor->thres_temp);
-       mutex_unlock(&data->thermal_lock);
 
        thermal_zone_device_update(data->sensors.tzd,
                                   THERMAL_EVENT_UNSPECIFIED);