Fix serial console on SNI RM400 machines
authorThomas Bogendoerfer <tsbogend@alpha.franken.de>
Wed, 31 May 2017 20:21:03 +0000 (22:21 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 3 Jun 2017 09:48:52 +0000 (18:48 +0900)
sccnxp driver doesn't get the correct uart clock rate, if CONFIG_HAVE_CLOCK
is disabled. Correct usage of clk API to make it work with/without it.

Fixes: 90efa75f7ab0 (serial: sccnxp: Using CLK API for getting UART clock)

Suggested-by: Russell King - ARM Linux <linux@armlinux.org.uk>
Signed-off-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/sccnxp.c

index fcf803ffad1931c45ee297d862209f3b09ae76d2..cdd2f942317c59fe4ec04c022a004d871f551fde 100644 (file)
@@ -884,14 +884,19 @@ static int sccnxp_probe(struct platform_device *pdev)
 
        clk = devm_clk_get(&pdev->dev, NULL);
        if (IS_ERR(clk)) {
-               if (PTR_ERR(clk) == -EPROBE_DEFER) {
-                       ret = -EPROBE_DEFER;
+               ret = PTR_ERR(clk);
+               if (ret == -EPROBE_DEFER)
                        goto err_out;
-               }
+               uartclk = 0;
+       } else {
+               clk_prepare_enable(clk);
+               uartclk = clk_get_rate(clk);
+       }
+
+       if (!uartclk) {
                dev_notice(&pdev->dev, "Using default clock frequency\n");
                uartclk = s->chip->freq_std;
-       } else
-               uartclk = clk_get_rate(clk);
+       }
 
        /* Check input frequency */
        if ((uartclk < s->chip->freq_min) || (uartclk > s->chip->freq_max)) {