staging: rtl8192e: Fix smatch warning in rtl_wx.c
authorLarry Finger <Larry.Finger@lwfinger.net>
Thu, 1 Sep 2011 17:23:16 +0000 (12:23 -0500)
committerGreg Kroah-Hartman <gregkh@suse.de>
Tue, 6 Sep 2011 23:35:57 +0000 (16:35 -0700)
Smatch reports the following warning:

  CHECK   drivers/staging/rtl8192e/rtl_wx.c

drivers/staging/rtl8192e/rtl_wx.c +262 r8192se_wx_set_radio(16) warn: inconsistent returns sem:&priv->wx_sem: locked (258) unlocked (262)

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/staging/rtl8192e/rtl_wx.c

index 77ea4bb8c7a18abd52ff5424560419c00dc26a4d..93b1edbe6baec5c7a3f543871759accab9393dd4 100644 (file)
@@ -255,6 +255,7 @@ static int r8192se_wx_set_radio(struct net_device *dev,
        if ((*extra != 0) && (*extra != 1)) {
                RT_TRACE(COMP_ERR, "%s(): set radio an err value,must 0(radio "
                         "off) or 1(radio on)\n", __func__);
+               up(&priv->wx_sem);
                return -1;
        }
        priv->sw_radio_on = *extra;