projects / GitHub / moto-9609 / android_kernel_motorola_exynos9610.git / commitdiff
? search:
summary | shortlog | log | commit | commitdiff | tree
raw | patch | inline | side by side (parent: c904ffd)
staging: most: Delete an unnecessary check before the function call "module_put"
authorMarkus Elfring <elfring@users.sourceforge.net>
Thu, 5 Nov 2015 13:34:43 +0000 (14:34 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 16 Nov 2015 04:02:47 +0000 (20:02 -0800)
The module_put() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/most/mostcore/core.c patch | blob | blame | history

diff --git a/drivers/staging/most/mostcore/core.c b/drivers/staging/most/mostcore/core.c
index 19852ca7e59c3ab8f463297fa548985629ba09e3..ed1ed25b6d1d27928419c768bf8898ea94e176ca 100644 (file)
--- a/drivers/staging/most/mostcore/core.c
+++ b/drivers/staging/most/mostcore/core.c
@@ -1587,8 +1587,7 @@ out:
        return 0;
 
 error:
-       if (iface->mod)
-               module_put(iface->mod);
+       module_put(iface->mod);
        modref--;
        mutex_unlock(&c->start_mutex);
        return ret;