rtc: rtctest: enabling UIE for a chip that doesn't support it returns EINVAL
authorUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Wed, 16 Sep 2015 07:16:51 +0000 (09:16 +0200)
committerAlexandre Belloni <alexandre.belloni@free-electrons.com>
Mon, 2 Nov 2015 23:50:46 +0000 (00:50 +0100)
Calling ioctl(..., RTC_UIE_ON, ...) without CONFIG_RTC_INTF_DEV_UIE_EMUL
either ends in rtc_update_irq_enable if rtc->uie_unsupported is true
or in __rtc_set_alarm in the if (!rtc->ops->set_alarm) branch. In both
cases the return value is -EINVAL. So check for that one instead of
ENOTTY.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
tools/testing/selftests/timers/rtctest.c

index d80ae852334d1560522f0b74034479bf7efe00d1..624bce51b27d26fad9a88528a71439125a20d183 100644 (file)
@@ -61,7 +61,7 @@ int main(int argc, char **argv)
        /* Turn on update interrupts (one per second) */
        retval = ioctl(fd, RTC_UIE_ON, 0);
        if (retval == -1) {
-               if (errno == ENOTTY) {
+               if (errno == EINVAL) {
                        fprintf(stderr,
                                "\n...Update IRQs not supported.\n");
                        goto test_READ;