nfsd: clean up helper __release_lock_stateid

Use filp_close instead of open coding. filp_close does a bit more than
just release the locks and put the filp. It also calls ->flush and
dnotify_flush, both of which should be done here anyway.

Signed-off-by: Trond Myklebust <trond.myklebust@primarydata.com>
Signed-off-by: Jeff Layton <jlayton@primarydata.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: J. Bruce Fields <bfields@redhat.com>

diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c
index 314dc806146112f5830ac13506fd4ad0cd72c8ea..4ab567e7db0f5d5779176bb88b40c9c9d31bb5a2 100644 (file)
--- a/fs/nfsd/nfs4state.c
+++ b/fs/nfsd/nfs4state.c
@@ -821,10 +821,8 @@ static void __release_lock_stateid(struct nfs4_ol_stateid *stp)
        unhash_generic_stateid(stp);
        unhash_stid(&stp->st_stid);
        file = find_any_file(stp->st_file);
-       if (file) {
-               locks_remove_posix(file, (fl_owner_t)lockowner(stp->st_stateowner));
-               fput(file);
-       }
+       if (file)
+               filp_close(file, (fl_owner_t)lockowner(stp->st_stateowner));
        close_generic_stateid(stp);
        free_generic_stateid(stp);
 }