[media] rtl28xxu: fix rtl2832u module reload fails bug
authorAntti Palosaari <crope@iki.fi>
Tue, 21 Aug 2012 22:56:19 +0000 (19:56 -0300)
committerMauro Carvalho Chehab <mchehab@redhat.com>
Sat, 15 Sep 2012 12:29:49 +0000 (09:29 -0300)
This is workaround / partial fix.

rtl2832u_power_ctrl() and rtl2832u_frontend_attach() needs to
be go through carefully and fix properly. There is clearly
some logical errors when handling power-management ang GPIOs...

Signed-off-by: Antti Palosaari <crope@iki.fi>
Cc: Thomas Mair <thomas.mair86@googlemail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
drivers/media/usb/dvb-usb-v2/rtl28xxu.c

index 1ccb99b0a2043a61a59406976f708c7a74ba2f7a..c246c50be6295c6ecfebf94b8b383e63a1ee9796 100644 (file)
@@ -942,17 +942,6 @@ static int rtl2832u_power_ctrl(struct dvb_usb_device *d, int onoff)
                /* bit 7 to 1 */
                val |= 0x80;
 
-               ret = rtl28xx_wr_reg(d, SYS_DEMOD_CTL, val);
-               if (ret)
-                       goto err;
-
-               /* demod HW reset */
-               ret = rtl28xx_rd_reg(d, SYS_DEMOD_CTL, &val);
-               if (ret)
-                       goto err;
-               /* bit 5 to 0 */
-               val &= 0xdf;
-
                ret = rtl28xx_wr_reg(d, SYS_DEMOD_CTL, val);
                if (ret)
                        goto err;