nvme: update and rename nvme_cancel_io to nvme_cancel_request
authorMing Lin <ming.l@samsung.com>
Wed, 18 May 2016 21:05:01 +0000 (14:05 -0700)
committerJens Axboe <axboe@fb.com>
Tue, 7 Jun 2016 19:43:02 +0000 (13:43 -0600)
nvme_cancel_io is a bit confusing (given the distinction of io/admin),
so rename it to nvme_cancel_request.

And update it a bit to pass in struct nvme_ctrl, so it can be used
by Fabrics driver also.

Signed-off-by: Ming Lin <ming.l@samsung.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Suggested-by: Sagi Grimberg <sagi@grimberg.me>
Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
Reviewed-by: Keith Busch <keith.bsuch@intel.com>
Signed-off-by: Jens Axboe <axboe@fb.com>
drivers/nvme/host/pci.c

index 78dca3193ca4ccc61df9784ff7699834c61e08b2..4af61c909353511e2a2c6184aa9e56b649224c61 100644 (file)
@@ -919,14 +919,14 @@ static enum blk_eh_timer_return nvme_timeout(struct request *req, bool reserved)
        return BLK_EH_RESET_TIMER;
 }
 
-static void nvme_cancel_io(struct request *req, void *data, bool reserved)
+static void nvme_cancel_request(struct request *req, void *data, bool reserved)
 {
        int status;
 
        if (!blk_mq_request_started(req))
                return;
 
-       dev_dbg_ratelimited(((struct nvme_dev *) data)->ctrl.device,
+       dev_dbg_ratelimited(((struct nvme_ctrl *) data)->device,
                                "Cancelling I/O %d", req->tag);
 
        status = NVME_SC_ABORT_REQ;
@@ -1722,8 +1722,8 @@ static void nvme_dev_disable(struct nvme_dev *dev, bool shutdown)
        }
        nvme_pci_disable(dev);
 
-       blk_mq_tagset_busy_iter(&dev->tagset, nvme_cancel_io, dev);
-       blk_mq_tagset_busy_iter(&dev->admin_tagset, nvme_cancel_io, dev);
+       blk_mq_tagset_busy_iter(&dev->tagset, nvme_cancel_request, &dev->ctrl);
+       blk_mq_tagset_busy_iter(&dev->admin_tagset, nvme_cancel_request, &dev->ctrl);
        mutex_unlock(&dev->shutdown_lock);
 }