b43/leds: Ensure NUL-termination of LED name string
authorMichael Buesch <m@bues.ch>
Tue, 31 Jul 2018 19:14:04 +0000 (21:14 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 5 Sep 2018 07:26:39 +0000 (09:26 +0200)
commit 2aa650d1950fce94f696ebd7db30b8830c2c946f upstream.

strncpy might not NUL-terminate the string, if the name equals the buffer size.
Use strlcpy instead.

Signed-off-by: Michael Buesch <m@bues.ch>
Cc: stable@vger.kernel.org
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/net/wireless/broadcom/b43/leds.c

index cb987c2ecc6bf5295684c11da9604c03ef4d2e32..87131f6632929963506d0258d1bc20c97c09e5b8 100644 (file)
@@ -131,7 +131,7 @@ static int b43_register_led(struct b43_wldev *dev, struct b43_led *led,
        led->wl = dev->wl;
        led->index = led_index;
        led->activelow = activelow;
-       strncpy(led->name, name, sizeof(led->name));
+       strlcpy(led->name, name, sizeof(led->name));
        atomic_set(&led->state, 0);
 
        led->led_dev.name = led->name;