TTY: msm_serial, remove unneeded console set
authorJiri Slaby <jslaby@suse.cz>
Thu, 14 Jul 2011 12:35:11 +0000 (14:35 +0200)
committerGreg Kroah-Hartman <gregkh@suse.de>
Tue, 23 Aug 2011 17:34:05 +0000 (10:34 -0700)
It doesn't make sense to set console to uart_port in console->setup.
At that time the console is set by uart_add_one_port already.

The call chain looked like:
uart_add_one_port()
  uport->cons = drv->cons;   <= once
  uart_configure_port()
    register_console()
     console->setup()
       port->cons = co;      <= second time

Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Cc: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/tty/serial/msm_serial.c

index e6ba83876508e9318843757b15f3b3cba4e77f1c..29cbfd8c4e7c858679a3f397d9bd71ccb0dcbf25 100644 (file)
@@ -804,8 +804,6 @@ static int __init msm_console_setup(struct console *co, char *options)
        if (unlikely(!port->membase))
                return -ENXIO;
 
-       port->cons = co;
-
        msm_init_clock(port);
 
        if (options)