projects / GitHub / moto-9609 / android_kernel_motorola_exynos9610.git / commitdiff
? search:
summary | shortlog | log | commit | commitdiff | tree
raw | patch | inline | side by side (parent: 5d66fe9)
atarilance: timeout ignored in lance_open()
authorroel kluin <roel.kluin@gmail.com>
Sun, 27 Dec 2009 03:26:12 +0000 (03:26 +0000)
committerDavid S. Miller <davem@davemloft.net>
Mon, 4 Jan 2010 05:42:52 +0000 (21:42 -0800)
With `while (--i > 0)' i reaches 0 after the loop, so upon timeout the
error was not issued.

Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/atarilance.c patch | blob | blame | history

diff --git a/drivers/net/atarilance.c b/drivers/net/atarilance.c
index c5721cb3826598e6f3fb143a0097325910c55311..cc9ed8643910e3869ebdbcc05deddd42c0ba9c57 100644 (file)
--- a/drivers/net/atarilance.c
+++ b/drivers/net/atarilance.c
@@ -663,7 +663,7 @@ static int lance_open( struct net_device *dev )
        while (--i > 0)
                if (DREG & CSR0_IDON)
                        break;
-       if (i < 0 || (DREG & CSR0_ERR)) {
+       if (i <= 0 || (DREG & CSR0_ERR)) {
                DPRINTK( 2, ( "lance_open(): opening %s failed, i=%d, csr0=%04x\n",
                                          dev->name, i, DREG ));
                DREG = CSR0_STOP;