ACPI: EC: Restart command even if no interrupts from EC
authorAlexey Starikovskiy <astarikovskiy@suse.de>
Thu, 1 Oct 2009 22:53:15 +0000 (02:53 +0400)
committerLen Brown <len.brown@intel.com>
Fri, 2 Oct 2009 14:00:31 +0000 (10:00 -0400)
EC may forget a command without sending any "reset" interrupt,
thus we need to lessen the requirement for transaction restart.

Reference: http://bugzilla.kernel.org/show_bug.cgi?id=14247
Signed-off-by: Alexey Starikovskiy <astarikovskiy@suse.de>
Signed-off-by: Len Brown <len.brown@intel.com>
drivers/acpi/ec.c

index f70796081c4c0ad93c0e5c751cc2297b81dea9f4..8a4897d3899d30b8443dfb90c08a0b499b34ede0 100644 (file)
@@ -232,10 +232,8 @@ static int ec_poll(struct acpi_ec *ec)
                        }
                        advance_transaction(ec, acpi_ec_read_status(ec));
                } while (time_before(jiffies, delay));
-               if (!ec->curr->irq_count ||
-                   (acpi_ec_read_status(ec) & ACPI_EC_FLAG_IBF))
+               if (acpi_ec_read_status(ec) & ACPI_EC_FLAG_IBF)
                        break;
-               /* try restart command if we get any false interrupts */
                pr_debug(PREFIX "controller reset, restart transaction\n");
                spin_lock_irqsave(&ec->curr_lock, flags);
                start_transaction(ec);