xfs: remove unnecessary parentheses from log redo item recovery functions
authorDarrick J. Wong <darrick.wong@oracle.com>
Wed, 3 Aug 2016 02:29:32 +0000 (12:29 +1000)
committerDave Chinner <david@fromorbit.com>
Wed, 3 Aug 2016 02:29:32 +0000 (12:29 +1000)
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
Signed-off-by: Dave Chinner <david@fromorbit.com>
fs/xfs/xfs_extfree_item.c
fs/xfs/xfs_rmap_item.c

index a8c461735ecb2f0afe6a838ec7fd279290e9e84b..d7bc14906af87f14ef570a968ead42100445c8bd 100644 (file)
@@ -515,13 +515,13 @@ xfs_efi_recover(
         * just toss the EFI.
         */
        for (i = 0; i < efip->efi_format.efi_nextents; i++) {
-               extp = &(efip->efi_format.efi_extents[i]);
+               extp = &efip->efi_format.efi_extents[i];
                startblock_fsb = XFS_BB_TO_FSB(mp,
                                   XFS_FSB_TO_DADDR(mp, extp->ext_start));
-               if ((startblock_fsb == 0) ||
-                   (extp->ext_len == 0) ||
-                   (startblock_fsb >= mp->m_sb.sb_dblocks) ||
-                   (extp->ext_len >= mp->m_sb.sb_agblocks)) {
+               if (startblock_fsb == 0 ||
+                   extp->ext_len == 0 ||
+                   startblock_fsb >= mp->m_sb.sb_dblocks ||
+                   extp->ext_len >= mp->m_sb.sb_agblocks) {
                        /*
                         * This will pull the EFI from the AIL and
                         * free the memory associated with it.
@@ -539,7 +539,7 @@ xfs_efi_recover(
 
        xfs_rmap_skip_owner_update(&oinfo);
        for (i = 0; i < efip->efi_format.efi_nextents; i++) {
-               extp = &(efip->efi_format.efi_extents[i]);
+               extp = &efip->efi_format.efi_extents[i];
                error = xfs_trans_free_extent(tp, efdp, extp->ext_start,
                                              extp->ext_len, &oinfo);
                if (error)
index 7e4743219430bc8e203b132a2cd15fd08244e8da..2500f28689d5b1d25e9bcd6d64fabe047dc7b1fb 100644 (file)
@@ -454,7 +454,7 @@ xfs_rui_recover(
         * just toss the RUI.
         */
        for (i = 0; i < ruip->rui_format.rui_nextents; i++) {
-               rmap = &(ruip->rui_format.rui_extents[i]);
+               rmap = &ruip->rui_format.rui_extents[i];
                startblock_fsb = XFS_BB_TO_FSB(mp,
                                   XFS_FSB_TO_DADDR(mp, rmap->me_startblock));
                switch (rmap->me_flags & XFS_RMAP_EXTENT_TYPE_MASK) {
@@ -469,10 +469,10 @@ xfs_rui_recover(
                        op_ok = false;
                        break;
                }
-               if (!op_ok || (startblock_fsb == 0) ||
-                   (rmap->me_len == 0) ||
-                   (startblock_fsb >= mp->m_sb.sb_dblocks) ||
-                   (rmap->me_len >= mp->m_sb.sb_agblocks) ||
+               if (!op_ok || startblock_fsb == 0 ||
+                   rmap->me_len == 0 ||
+                   startblock_fsb >= mp->m_sb.sb_dblocks ||
+                   rmap->me_len >= mp->m_sb.sb_agblocks ||
                    (rmap->me_flags & ~XFS_RMAP_EXTENT_FLAGS)) {
                        /*
                         * This will pull the RUI from the AIL and
@@ -490,7 +490,7 @@ xfs_rui_recover(
        rudp = xfs_trans_get_rud(tp, ruip);
 
        for (i = 0; i < ruip->rui_format.rui_nextents; i++) {
-               rmap = &(ruip->rui_format.rui_extents[i]);
+               rmap = &ruip->rui_format.rui_extents[i];
                state = (rmap->me_flags & XFS_RMAP_EXTENT_UNWRITTEN) ?
                                XFS_EXT_UNWRITTEN : XFS_EXT_NORM;
                whichfork = (rmap->me_flags & XFS_RMAP_EXTENT_ATTR_FORK) ?