UBI: make the control character device non-seekable
authorArtem Bityutskiy <Artem.Bityutskiy@nokia.com>
Mon, 21 Mar 2011 14:50:18 +0000 (16:50 +0200)
committerArtem Bityutskiy <Artem.Bityutskiy@nokia.com>
Thu, 14 Apr 2011 08:34:40 +0000 (11:34 +0300)
This patch makes the UBI control device (/dev/ubi_ctrl) non-seekable.
The seek operation does is not applicable to this file, so it is
cleaner to explicitly return error (which the added 'no_llseek()')
does than trying to change the position (which the removed
'default_llseek()' does).

This is an API break, but the only known user of this interface is
mtd-utils which does not need the seeking functionality. And any app
which relies on this is broken, but I'm not aware of such apps.

Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
drivers/mtd/ubi/cdev.c

index af9fb0ff8210d5b3d34c3a2e788123b2a7745aaf..9a1703286411a54ae8a8882f8f3d668a28392793 100644 (file)
@@ -1100,5 +1100,5 @@ const struct file_operations ubi_ctrl_cdev_operations = {
        .owner          = THIS_MODULE,
        .unlocked_ioctl = ctrl_cdev_ioctl,
        .compat_ioctl   = ctrl_cdev_compat_ioctl,
-       .llseek         = noop_llseek,
+       .llseek         = no_llseek,
 };