atm: Cleanup redundant tests on unsigned
authorroel kluin <roel.kluin@gmail.com>
Fri, 23 Oct 2009 06:09:55 +0000 (06:09 +0000)
committerDavid S. Miller <davem@davemloft.net>
Thu, 29 Oct 2009 08:39:55 +0000 (01:39 -0700)
The variables are unsigned so the `< 0' test always fails, the
other part of the test catches wrapped values.

Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/atm/fore200e.c
drivers/atm/he.c

index f766cc46b4c4346ae3a08897af1563097001ec0a..bc53fed89b1e5d5199b929c5ad36c76bf983c4ff 100644 (file)
@@ -2906,8 +2906,8 @@ fore200e_proc_read(struct atm_dev *dev, loff_t* pos, char* page)
        u32 media_index    = FORE200E_MEDIA_INDEX(fore200e->bus->read(&fore200e->cp_queues->media_type));
        u32 oc3_index;
 
-       if ((media_index < 0) || (media_index > 4))
-           media_index = 5;
+       if (media_index > 4)
+               media_index = 5;
        
        switch (fore200e->loop_mode) {
            case ATM_LM_NONE:    oc3_index = 0;
index 70667033a5687ee38e07a2ce220f2f91fbb2fa2a..e90665876c4774ffa92cbccee1629c10f388ad80 100644 (file)
@@ -2739,7 +2739,7 @@ he_ioctl(struct atm_dev *atm_dev, unsigned int cmd, void __user *arg)
                        spin_lock_irqsave(&he_dev->global_lock, flags);
                        switch (reg.type) {
                                case HE_REGTYPE_PCI:
-                                       if (reg.addr < 0 || reg.addr >= HE_REGMAP_SIZE) {
+                                       if (reg.addr >= HE_REGMAP_SIZE) {
                                                err = -EINVAL;
                                                break;
                                        }